View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0025764 | mantisbt | public | 2019-05-15 19:44 | 2021-03-07 18:28 | |
Reporter | TomekAP | Assigned To | dregad | ||
Priority | normal | Severity | feature | Reproducibility | N/A |
Status | closed | Resolution | fixed | ||
Target Version | 2.25.0 | Fixed in Version | 2.25.0 | ||
Summary | 0025764: Enable S/MIME signed e-mail notifications | ||||
Description | Now emails can not be signed, nevertheless, there is such option in phpmailer. I suggest adding in email_api.php at the end of section "case PHPMAILER_METHOD_SMTP:" $t_mail->sign(config_get_global('cert_filename'), config_get_global('key_filename'), config_get_global('key_pass'), config_get_global('extracerts_filename ')); And add some variables in config_defaults_inc.php: And in config_defaults_inc.php
/**
/**
/**
| ||||
Tags | No tags attached. | ||||
Feel free to submit a pull request on Github with a proposed implementation for review. |
|
I created branch, but can not push it: |
|
You need to push to your own fork repository, i.e. https://github.com/TomekAP/mantisbt.git then on the GitHub UI, submit a pull request. |
|
now I hpe it is OK: |
|
@TomekAP almost there... you just need to actually click the Create pull request button to submit it for review. |
|
Now is it OK? |
|
That's it. Will review as time allows |
|
MantisBT: master 1bf2f040 2021-01-08 08:57 tsz Committer: dregad Details Diff |
Enable S/MIME signing of e-mails Use existing PHPMailer functionality to allow MantisBT to sign outgoing e-mail notifications. Fixes 0025764 Signed-off-by: Damien Regad <dregad@mantisbt.org> TomekAP's original contribution was modified as follows: - Fix inconsistent naming of 'g_email_signing_sign_extracerts_file' in config_defaults_inc.php, referenced everywhere else as 'g_email_signing_extracerts_file' - Rename configs with prefix 'smime' instead of 'signing', to avoid any confusion with DKIM which is also about signing - Use suffix '_file' instead of '_filename' - Fix whitespace |
Affected Issues 0025764 |
|
mod - config_defaults_inc.php | Diff File | ||
mod - core/email_api.php | Diff File | ||
MantisBT: master 741d91f5 2021-01-08 08:59 Details Diff |
Updated PHPDoc and added new configs in Admin Guide Created a new 'S/MIME signature' section under Config / Email. Issue 0025764 |
Affected Issues 0025764 |
|
mod - config_defaults_inc.php | Diff File | ||
mod - docbook/Admin_Guide/en-US/config/email.xml | Diff File | ||
MantisBT: master cb13a049 2021-01-08 09:05 Details Diff |
Allow S/MIME signature for all mail methods The original implementation only enabled S/MIME signature for PHPMAILER_METHOD_SMTP. Moving the call to PHPMailer::sign() out of the switch() statement, so it is also called when mail method is PHPMAILER_METHOD_SENDMAIL or PHPMAILER_METHOD_MAIL. Fixes 0025764 |
Affected Issues 0025764 |
|
mod - core/email_api.php | Diff File | ||
MantisBT: master e09ea350 2021-01-08 09:21 Details Diff |
Add new $g_email_smime_enable setting This allows calling PHPMailer::sign() only if necessary, and avoids 4 unnecessary config_get_global() calls if not. Fixes 0025764 |
Affected Issues 0025764 |
|
mod - config_defaults_inc.php | Diff File | ||
mod - core/email_api.php | Diff File | ||
mod - docbook/Admin_Guide/en-US/config/email.xml | Diff File |