View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0027362 | mantisbt | installation | public | 2020-09-27 17:55 | 2021-03-07 18:28 |
Reporter | sam888 | Assigned To | dregad | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | 2.24.2 | ||||
Target Version | 2.25.0 | Fixed in Version | 2.25.0 | ||
Summary | 0027362: Sourceforge [admin/test_langs.php] File missing from installation packages ( mantisbt-2.24.3.zip & mantisbt-2.24.3.tar.gz) | ||||
Description | The release files on Github contain [admin/test_langs.php] . | ||||
Steps To Reproduce | Un-archive the release files and look in the admin directory for test_langs.php | ||||
Additional Information | https://github.com/mantisbt/mantisbt/tree/master/admin https://sourceforge.net/projects/mantisbt/files/mantis-stable/2.24.3/ https://github.com/mantisbt/mantisbt/releases/tag/release-2.24.3 Question: Attemping to install from the Github release files gives the following error (but works with the sourceforge release files!) [27-Sep-2020 20:56:33 UTC] PHP Fatal error: require_once(): Failed opening required '/home/hostname/public_html/mantisbt/vendor/autoload.php' (include_path='.:/opt/cpanel/ea-php72/root/usr/share/pear') in /home/hostname/public_html/mantis/core.php on line 91 | ||||
Tags | No tags attached. | ||||
related to | 0027057 | closed | dregad | PHP Fatal error: Uncaught Error: Call to undefined method ComposerAutoloaderInitfa60a1d30e82198ab309dba1a3049801 |
related to | 0026903 | closed | vboctor | Move release scripts to main repository |
related to | 0027384 | closed | dregad | Upgrade release build scripts to Python3 |
related to | 0027383 | closed | dregad | Refactor and improve output of 'test_langs.php' admin script |
Worked out my question 0027057:0064124 <i>If you use the "official" install package from SourceForge, then you don't need to run Composer, the libraries are bundled in the tarball. Running Composer yourself is only needed if you get the MantisBT source from GitHub.</i> Suggestion maybe add a message about to the release on Github ( you can edit each release we do it for the Gramps project). |
|
Our problems is that we can't tag without creating a release on GitHub, see this discussion. |
|
@atrol ? You answered my secondary question. What about the primary issue I raise that you just resolved how are the files for sourceforge generated because files are missing? |
|
@sam888 you are right. |
|
Assigning to @dregad who prepared the 2.24.2 and 2.24.3 releases. |
|
Regarding the releases page on GitHub I created a dummy release to inform user not to use these zip/tarballs. I need to look into what happened with the release build script, that caused some files to be missing. |
|
So the absence of test_langs.php in the tarballs is due to the release build script specifically excluding it. This was introduced as part of moving the release scripts into the main repo (see 0026903): I have no idea why @vboctor decided to exclude that file and maybe he'll care to comment, but considering that it is still referenced in the Admin pages' GUI, I guess that the change may have been unintentional. Or if it was done on purpose, then it should have been properly and fully removed from the code base. |
|
So this is how it looks now: |
|
@dregad I probably removed it since it is a dev script like the test cases, composer files, etc. However, I missed that it had a link from the admin page. I would suggest removing the link to it from admin experience. |
|
The script can be useful for admins to check language files of 3rd party plugins. |
|
I agree. I propose to revert the exclusion from the build script, bundle 2.24.2 + 2.24.3 again, and republish the tarballs to SourceForge. The test_langs.php script is very dated. Its output is crap, and it contains obsolete code for PHP 4 compatibility (!). Maybe we can refactor it into a new section of our admin checks process, what do you think ? |
|
OK, so without further feedback I'll proceed with reverting and rebuild the tarballs. I have opened 0027383 to track refactoring of test_langs.php. |
|
Updated tarballs for 2.24.2 and 2.24.3 have been uploaded to Sourceforge. |
|
Thank you |
|