View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0028080 | mantisbt | ui | public | 2021-03-17 10:47 | 2021-05-13 06:58 |
Reporter | LukeWCS | Assigned To | dregad | ||
Priority | low | Severity | tweak | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | 2.25.0 | ||||
Target Version | 2.25.1 | Fixed in Version | 2.25.1 | ||
Summary | 0028080: Unsightly vertical offset of the "Update Prefs" and "Reset Prefs" buttons. | ||||
Description | This offset did not yet exist in 2.24.4, it has only occurred since 2.25.0. | ||||
Steps To Reproduce | With Opera or Vivaldi:
| ||||
Additional Information | Tested browser:
| ||||
Tags | No tags attached. | ||||
Attached Files | |||||
Suppose this is caused by 0027574 |
|
Yes, it seems to affect all Blink based browsers. More tests:
|
|
I confirm the behavior also (Chromium 89.0.4389.90). This is indeed a regression from 0027574, as @atrol suspected - see commit MantisBT master f65b0cae The Reset Prefs button is displayed via print_form_button() API, which generates an HTML form including a Considering that this fieldset is not really useful in this context, we might as well get rid of it. |
|
MantisBT: master f65b0cae 2020-11-21 13:19 Details Diff |
Fix markup in account_prefs_inc.php The sequence of wrapping divs was different from the usual layout, causing inconsistent spacing when the account preferences section was displayed on manage_user_edit_page.php. edit_account_prefs() no longer prints the outer div, letting the parent page take care of it. Fixes 0027574 |
Affected Issues 0027574, 0028080 |
|
mod - account_prefs_inc.php | Diff File | ||
mod - account_prefs_page.php | Diff File | ||
mod - manage_user_edit_page.php | Diff File | ||
MantisBT: master-2.25 623c74b6 2021-03-17 10:26 Details Diff |
Remove <fieldset> from print_form_button() markup Fixes 0028080 |
Affected Issues 0028080 |
|
mod - core/print_api.php | Diff File |