Used "Move Attachments to Disk" after years and found that this system tool still leads to data loss due to overwritten files since in admin/move_db2disk.php function upgrade_move_att2disk the filenames on disk are not made unique like in core/file_api.php (implemented via function file_generate_unique_name).

Note: this error has already been noted several times, e.g., in 0007176, 0009495, 0005836 -- please fix.
This tool is only required every now and then, but when you stumble over that problem during a major mantis upgrade you can really get into trouble as an admin.

Furthermore, upgrade_move_att2disk does not apply the file permissions as specified in $g_attachments_file_permissions.