View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0014466 | mantisbt | db postgresql | public | 2012-07-09 09:11 | 2014-09-23 18:05 |
Reporter | mva | Assigned To | dregad | ||
Priority | normal | Severity | major | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | 1.2.11 | ||||
Target Version | 1.2.12 | Fixed in Version | 1.2.12 | ||
Summary | 0014466: New Signup user has protected account | ||||
Description | If user sign up, receiveed email and go to ling then get error 'Account protected'. Problem in file user_api.php>>function user_create line 483 exists if( $c_protected ) { correct if( $p_protected ) { | ||||
Tags | No tags attached. | ||||
Which database do you use? |
|
PostgreSQL |
|
This is probably a side effect of 0014288 - will have a look. Note: removing relationship to 0014398 which deals with issues related to 1.3, not the case here |
|
dregad, you set the same relationship at 0014385. So I thought it is a good idea to add it also here. |
|
Hm-m, on my opinion error in php code and indpendentd from database platform. At user_api.php line 457 $c_protected = db_prepare_bool( $p_protected ); $c_protected always has value! At user_api.php line 457
Always set new user to protected state! I'm sorry if this note was unnecessary |
|
I had a bad gut feeling when seeing this commit.
Our real problem is, that we don't have enough automated tests to make such kind of changes without fearing to break existing functionality. |
|
mva, if( $c_protected ) doesn't mean "has a value" it means "is true" |
|
Marking as 'acknowledged' not resolved/closed to track that change gets ported to master-2.0.x branch |
|
MantisBT currently supports Mysql and has support for other database engines. The support for other databases is known to be problematic. Having implemented the current database layer into Mantis 10 years ago, I'm currently working on replacing the current layer. If you are interested in using Mantis with non-mysql databases - for example, Oracle, PGSQL or MSSQL, and would be willing to help out testing the new database layer, please drop me an email at paul@mantisforge.org In the meantime, I'd advise running Mantis with Mysql Only to avoid issues. Thanks |
|
MantisBT: master d9e97d9e 2012-08-01 13:34 Details Diff |
Fix new signup user is protected account on PostgreSQL This fixes a regression introduced with resolution of 0014288 (see commit b8d4b5039598248d0b0c78619450c51d4dc98df2) The user_create() function was not properly resetting the account's protected flag to false due to specific handling of Boolean type as a string for PostgreSQL. Fixes 0014466 |
Affected Issues 0014466 |
|
mod - core/user_api.php | Diff File | ||
MantisBT: master-1.2.x 7124ee6f 2012-08-01 13:34 Details Diff |
Fix new signup user is protected account on PostgreSQL This fixes a regression introduced with resolution of 0014288 (see commit b8d4b5039598248d0b0c78619450c51d4dc98df2) The user_create() function was not properly resetting the account's protected flag to false due to specific handling of Boolean type as a string for PostgreSQL. Fixes 0014466 |
Affected Issues 0014466 |
|
mod - core/user_api.php | Diff File |