0034042: MantisGraph: inefficient calculation of data sets for Issue Trends graph - MantisBT

ID	Project	Category	View Status	Date Submitted	Last Update

0034042	mantisbt	performance	public	2024-03-13 14:11	2024-03-19 08:40

Reporter	dregad	Assigned To	dregad
Priority	normal	Severity	tweak	Reproducibility	always
Status	resolved	Resolution	fixed
Target Version	2.27.0	Fixed in Version	2.27.0

Summary	0034042: MantisGraph: inefficient calculation of data sets for Issue Trends graph
Description	The create_cumulative_bydate() function is executing simple SQL queries returning atomic data, and the PHP code has to loop over each row to compute the total number of reported and resolved Issues. This can be achieved much more efficiently by refactoring the SQL to let the database server aggregate the data, resulting in much simpler and faster PHP code.
Tags	No tags attached.

MantisBT: master f109d15d 2024-03-13 14:13 dregad Details Diff	Optimize create_cumulative_bydate() function Until today, the function was executing simple SQL queries returning atomic data, and PHP code had to loop over each row to compute the total number of reported and resolved Issues. This reports the effort to aggregate the data on the database server, greatly simplifying the PHP code It also fixes a bug where the last resolved issue was sometimes not computed, resulting in an incorrect result set. Fixes 0034041,0034042		Affected Issues 0034041, 0034042
	mod - plugins/MantisGraph/core/graph_api.php		Diff File

dregad 2024-03-13 14:22 developer ~0068652	PR https://github.com/mantisbt/mantisbt/pull/1975

dregad 2024-03-13 14:26 developer ~0068653	Changing target to 2.27.0 as the fix relies on PHP 7.4 syntax for heredocs, and I can't be bothered to make 2 versions of the fix...