View Issue Details

IDProjectCategoryView StatusLast Update
0007257mantisbtbugtrackerpublic2006-09-12 00:52
Reporterthraxisp Assigned Tothraxisp  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product Version1.0.3 
Fixed in Version1.1.0a1 
Summary0007257: Port: Fix for 0006869 / 0007034 removes quoted "?" from arguments
Description

The fix for 0006869 / 0007034 (in cvs) removes quoted "?" from arguments with the lines


function string_sanitize_url( $p_url ) {
[...]
$t_url = strip_tags( urldecode( $p_url ) );
[...]
$t_param = str_replace( '?','', $t_param );

Is there some security reason for this? I have not found a code break in a release version, but it breaks my patch in 0005432. This produces urls like:


set_project.php?project_id=7&make_default=no&ref=bug_view_page.php%3Fbug_id%3D4230

after string_sanitize_url this is transformed to


set_project.php?project_id=7&make_default=no&ref=bug_view_page.phpbug_id%3D4230

Note that the "%3f" for ? has been removed and the new url is invalid.

If there is no security reason for it, I would suggest removing the "$t_param = str_replace( '?','', $t_param );" line.

TagsNo tags attached.

Relationships

child of 0007051 closedthraxisp Fix for 0006869 / 0007034 removes quoted "?" from arguments 

Activities

thraxisp

thraxisp

2006-07-04 23:14

reporter   ~0013066

Fixed in CVS

core/string_api.php -> 1.82