View Issue Details

IDProjectCategoryView StatusLast Update
0008465mantisbtfilterspublic2007-10-24 02:27
Reporterpluntke Assigned Togiallu  
PrioritynormalSeverityfeatureReproducibilityhave not tried
Status closedResolutionfixed 
Product Version1.1.0rc1 
Fixed in Version1.1.0rc2 
Summary0008465: collapse filter section as default
Description

Many new users think the pages in Mantis to be overengineered.
Keep it simple! For the first time the "search" field would be enough, when looking for a more complex search engine you will find the filters when clicking on the "+" sign, but at first sight the page will look much cleaner without all the filter dropdown/edit fields.

Some code modification is shown here (not by me)
http://www.mantisbt.org/forums/viewtopic.php?t=2752

Maybe there's also another way (where is the filter setting beeing saved? as a cookie? then you only would have to change the default cookie)

TagsNo tags attached.
Attached Files
bug_8465.patch (882 bytes)   
Index: common.js
===================================================================
RCS file: /cvsroot/mantisbt/mantisbt/javascript/common.js,v
retrieving revision 1.10.2.1
diff -u -r1.10.2.1 common.js
--- common.js	13 Oct 2007 22:35:56 -0000	1.10.2.1
+++ common.js	16 Oct 2007 21:21:06 -0000
@@ -104,11 +104,25 @@
 var g_div_relationships	= 0x0080;
 var g_div_filter        = 0x0100;
 
+
+/* List here the sections open by default */
+var g_default_view_settings = 
+	g_div_history | 
+	g_div_bugnotes |
+	g_div_bugnote_add |
+	g_div_bugnote_add |
+	g_div_bugnotestats |
+	g_div_upload_form |
+	g_div_monitoring |
+	g_div_sponsorship |
+	g_div_relationships;
+
+
 function GetViewSettings() {
 	var t_cookie = GetCookie( "VIEW_SETTINGS" );
 
 	if ( -1 == t_cookie ) {
-		t_cookie = 0xffff;
+		t_cookie = g_default_view_settings;
 	} else {
 		t_cookie = parseInt( t_cookie );
 	}
bug_8465.patch (882 bytes)   

Relationships

has duplicate 0005661 closedgiallu Filter box too large 
has duplicate 0005596 closedvboctor Add support for 'collapsed by default' to collapse_api 

Activities

pluntke

pluntke

2007-10-15 05:06

reporter   ~0015871

The simple/advanced Filter buttons should always un-collapse the filter section!

pluntke

pluntke

2007-10-15 14:37

reporter   ~0015881

related to 0005596
seems more people are interested in this

pluntke

pluntke

2007-10-15 17:59

reporter   ~0015883

yes it seems to be very easy changing the default by changing the default cookie value:
in common.js change the t_cookie value like below:

function GetViewSettings() {
var t_cookie = GetCookie( "VIEW_SETTINGS" );

if ( -1 == t_cookie ) {
    t_cookie = 0xfeff;

changing the original value from 0xffff to 0xfeff will toggle the bit for filtering which is defined to be
var g_div_filter = 0x0100;

This change will only work for first time login (until the cookie is created) or you manually have to delete the MANTIS_VIEW_SETTINGS cookie.

The other sections' collapse default can be changed here as well.

giallu

giallu

2007-10-16 16:36

reporter   ~0015888

I agree with the proposed change. The full filters box looks like a bit scary, at least for new users.

I will ask for other opinions before modifying this default though.

vboctor

vboctor

2007-10-19 03:49

manager   ~0015906

I am ok with the change as long as if a user expands it once, it remains expanded in future sessions.

By the way, the following line is repeated twice in the patch:

  • g_div_bugnote_add |
giallu

giallu

2007-10-21 18:37

reporter   ~0015936

Oops, you are right: too much cut&paste there :)

fortunately, no harm is done being an OR operation.

giallu

giallu

2007-10-21 18:43

reporter   ~0015937

Fixed in BRANCH_1_1_0 (will merge on HEAD later)

BTW, I did not get the mail notication about your last comment :(

Related Changesets

MantisBT: master-1.1.x f1efebea

2007-10-21 18:39

giallu


Details Diff
Fix 8465: collapse filter section as default

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/branches/BRANCH_1_1_0@4658 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
Affected Issues
0008465
mod - javascript/common.js Diff File